linux-kernel - Re: [PATCH] NFS: fix potential NULL deref in nfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150321184732.GA5170@taesoo.org>
Date:	Sat, 21 Mar 2015 14:47:32 -0400
From:	Taesoo Kim <taesoo@...ech.edu>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Taesoo Kim <tsgatesv@...il.com>, trond.myklebust@...marydata.com,
	anna.schumaker@...app.com, linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, changwoo@...ech.edu,
	sanidhya@...ech.edu, blee@...ech.edu, csong84@...ech.edu,
	Byoungyoung Lee <lifeasageek@...il.com>
Subject: Re: [PATCH] NFS: fix potential NULL deref in nfs_closedir()

Ops. After reading nfs code, we also find out that nfs_opendir()
always allocates ctx obj (for private_data), unlike other fs allocate
private_data right before seeking dentries.

Sorry for the false alarm.

Taesoo

On 03/21/15 at 11:01am, Christoph Hellwig wrote:
> On Sat, Mar 21, 2015 at 12:21:18AM -0400, Taesoo Kim wrote:
> > From: Byoungyoung Lee <lifeasageek@...il.com>
> > 
> > When filp->private_data is NULL, put_nfs_open_dir_context()
> > deferences its pointer (fi->list, fi->cred), similar to what
> > other file systems handle '.release' api (9p, cifs, btrfs, 
> > ext4, ocfs2).
> 
> Why woud filp->private_data ever be NULL here?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/