linux-kernel - Re: [PATCH net] tcp: prevent fetching dst twice in early demux code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150323141250.GA4673@unicorn.suse.cz>
Date:	Mon, 23 Mar 2015 15:12:50 +0100
From:	Michal Kubecek <mkubecek@...e.cz>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH net] tcp: prevent fetching dst twice in early demux code

On Mon, Mar 23, 2015 at 06:49:02AM -0700, Eric Dumazet wrote:
> On Mon, 2015-03-23 at 09:27 +0100, Michal Kubecek wrote:
> > On s390x, gcc 4.8 compiles this part of tcp_v6_early_demux()
> > 
> >         struct dst_entry *dst = sk->sk_rx_dst;
> > 
> >         if (dst)
> >                 dst = dst_check(dst, inet6_sk(sk)->rx_dst_cookie);
> > 
> > to code reading sk->sk_rx_dst twice, once for the test and once for
> > the argument of ip6_dst_check() (dst_check() is inline). This allows
> > ip6_dst_check() to be called with null first argument, causing a crash.
> 
> Good catch, (or would I say, strange compiler ? ;) )

I was also surprised when I saw the code, considering that the code
saved registers %r6 through %r13 and didn't use most of them.

> Please use READ_ONCE().  Only stable ports will need ACCESS_ONCE()

I'll send v2 with READ_ONCE() in a moment.

> Also, this probably points a problem on this arch, because its looks
> different cpu are handling TCP traffic for the same TCP flow.

Good point, this will be worth looking into.

                                                        Michal Kubecek

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/