linux-kernel - Re: [PATCH] smack: Fix gcc warning from unused smack_syslog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55106968.3000204@schaufler-ca.com>
Date:	Mon, 23 Mar 2015 12:28:40 -0700
From:	Casey Schaufler <casey@...aufler-ca.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	James Morris <james.l.morris@...cle.com>,
	"Serge E. Hallyn" <serge@...lyn.com>
CC:	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [PATCH] smack: Fix gcc warning from unused smack_syslog_lock
 mutex in smackfs.c

On 3/23/2015 11:03 AM, Paul Gortmaker wrote:
> In commit 00f84f3f2e9d088f06722f4351d67f5f577abe22 ("Smack: Make the
> syslog control configurable") this mutex was added, but the rest of
> the final commit never actually made use of it, resulting in:
>
>  In file included from include/linux/mutex.h:29:0,
>                   from include/linux/notifier.h:13,
>                   from include/linux/memory_hotplug.h:6,
>                   from include/linux/mmzone.h:821,
>                   from include/linux/gfp.h:5,
>                   from include/linux/slab.h:14,
>                   from include/linux/security.h:27,
>                   from security/smack/smackfs.c:21:
>  security/smack/smackfs.c:63:21: warning: ‘smack_syslog_lock’ defined but not used [-Wunused-variable]
>   static DEFINE_MUTEX(smack_syslog_lock);
>                       ^
>
> A git grep shows no other instances/references to smack_syslog_lock.
> Delete it, assuming that the mutex addition was just a leftover from
> an earlier work in progress version of the change.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Acked-by: Casey Schaufler <casey@...aufler-ca.com>

I will take this patch into my smack-for-4.1 branch. Thank you.

> ---
>  security/smack/smackfs.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
> index bce4e8f1b267..558a46d76129 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -61,7 +61,6 @@ enum smk_inos {
>   */
>  static DEFINE_MUTEX(smack_cipso_lock);
>  static DEFINE_MUTEX(smack_ambient_lock);
> -static DEFINE_MUTEX(smack_syslog_lock);
>  static DEFINE_MUTEX(smk_netlbladdr_lock);
>  
>  /*

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/