linux-kernel - Re: Staging: slicoss: Fix checkpatch.pl issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427225161.12126.4.camel@perches.com>
Date:	Tue, 24 Mar 2015 12:26:01 -0700
From:	Joe Perches <joe@...ches.com>
To:	Niranjan Dighe <niranjan.dighe@...il.com>
Cc:	gregkh@...uxfoundation.org, liodot@...il.com,
	charrer@...critech.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: Staging: slicoss: Fix checkpatch.pl issues

On Wed, 2015-03-25 at 00:39 +0530, Niranjan Dighe wrote:
> The following files had coding style issues that I tried to address.
> It was mostly about lines spanning more than 80 characters.
[]
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
[]
> @@ -98,7 +98,8 @@
>  #include "slic.h"
>  
>  static uint slic_first_init = 1;
> -static char *slic_banner = "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)";
> +static char *slic_banner = "Alacritech SLIC Technology(tm) Server "
> +			"and Storage Accelerator (Non-Accelerated)";

Please don't split strings.

Maybe remove this and update the format in the one place
it's used instead.

> @@ -755,10 +756,10 @@ static bool slic_mac_filter(struct adapter *adapter,
>  
>  			while (mcaddr) {
>  				if (ether_addr_equal(mcaddr->address,
> -						     ether_frame->ether_dhost)) {
> -					adapter->rcv_multicasts++;
> -					netdev->stats.multicast++;
> -					return true;
> +					ether_frame->ether_dhost)) {
> +						adapter->rcv_multicasts++;
> +						netdev->stats.multicast++;
> +						return true;

80 columns is a preferred limit not a hard one.
The original is correct and your new indentation is not.

> @@ -2561,8 +2562,9 @@ static int slic_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
>  			DBG_IOCTL("slic_ioctl  SIOCSLIC_TRACE_DUMP\n");
>  
>  			if (copy_from_user(data, rq->ifr_data, 28)) {
> -				PRINT_ERROR
> -				    ("slic: copy_from_user FAILED getting initial simba param\n");
> +				PRINT_ERROR(
> +		"slic: copy_from_user FAILED getting initial simba param\n"
> +				);

Just remove all the #ifdef SLIC_TRACE_DUMP_ENABLED blocks,
PRINT_ERROR isn't defined anywhere. and this can't be compiled.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/