linux-kernel - Re: Staging: slicoss: Fix checkpatch.pl issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Mar 2015 23:14:29 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Niranjan Dighe <niranjan.dighe@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	charrer@...critech.com, liodot@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: Staging: slicoss: Fix checkpatch.pl issues

On Wed, Mar 25, 2015 at 12:39:06AM +0530, Niranjan Dighe wrote:
> The following files had coding style issues that I tried to address.
> It was mostly about lines spanning more than 80 characters.
> 
> Signed-off-by: Niranjan Dighe <niranjan.dighe@...il.com>
> 
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index 3104cb0..2161bdb 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -98,7 +98,8 @@
>  #include "slic.h"
>  
>  static uint slic_first_init = 1;
> -static char *slic_banner = "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)";
> +static char *slic_banner = "Alacritech SLIC Technology(tm) Server "
> +			"and Storage Accelerator (Non-Accelerated)";

Just leave it.  The original is better for grepping.

>  
>  static char *slic_proc_version = "2.0.351  2006/07/14 12:26:00";
>  
> @@ -755,10 +756,10 @@ static bool slic_mac_filter(struct adapter *adapter,
>  
>  			while (mcaddr) {
>  				if (ether_addr_equal(mcaddr->address,
> -						     ether_frame->ether_dhost)) {
> -					adapter->rcv_multicasts++;
> -					netdev->stats.multicast++;
> -					return true;
> +					ether_frame->ether_dhost)) {
> +						adapter->rcv_multicasts++;
> +						netdev->stats.multicast++;
> +						return true;
>  				}
>  				mcaddr = mcaddr->next;
>  			}

Check patch likes the new code but the original is better for human
beings.  Sorry.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/