linux-kernel - Re: Staging: slicoss: Fix checkpatch.pl issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1427228872.12126.8.camel@perches.com>
Date:	Tue, 24 Mar 2015 13:27:52 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Niranjan Dighe <niranjan.dighe@...il.com>,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	charrer@...critech.com, liodot@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: Staging: slicoss: Fix checkpatch.pl issues

On Tue, 2015-03-24 at 23:14 +0300, Dan Carpenter wrote:
> On Wed, Mar 25, 2015 at 12:39:06AM +0530, Niranjan Dighe wrote:
> > The following files had coding style issues that I tried to address.
> > It was mostly about lines spanning more than 80 characters.
[]
> > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
[]
> > @@ -755,10 +756,10 @@ static bool slic_mac_filter(struct adapter *adapter,
> >  
> >  			while (mcaddr) {
> >  				if (ether_addr_equal(mcaddr->address,
> > -						     ether_frame->ether_dhost)) {
> > -					adapter->rcv_multicasts++;
> > -					netdev->stats.multicast++;
> > -					return true;
> > +					ether_frame->ether_dhost)) {
> > +						adapter->rcv_multicasts++;
> > +						netdev->stats.multicast++;
> > +						return true;
> >  				}
> >  				mcaddr = mcaddr->next;
> >  			}
> 
> Check patch likes the new code but the original is better for human
> beings.  Sorry.

The indentation isn't correct in the new code either.

That's actually a checkpatch defect because it's not
able to track deletion/insertion alignment well enough.

Niranjan, checkpatch is a brainless little tool.
Always use yours whenever using checkpatch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/