linux-kernel - Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150324202936.GA31749@fuloong-minipc.musicnaut.iki.fi>
Date:	Tue, 24 Mar 2015 22:29:36 +0200
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	pauldaviesc@...il.com, nitinkuppelur@...il.com,
	linux-kernel@...r.kernel.org, br@...amon.org
Subject: Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between
 function name and opening bracket

Hi,

On Tue, Mar 24, 2015 at 08:08:16AM -0400, Nicholas Krause wrote:
> On March 24, 2015 3:08:09 AM EDT, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> >On Mon, Mar 23, 2015 at 05:08:52PM -0400, Nicholas Krause wrote:
> >> On March 23, 2015 9:06:26 AM EDT, Dan Carpenter
> ><dan.carpenter@...cle.com> wrote:
> >> >On Mon, Mar 23, 2015 at 08:53:19AM -0400, Nicholas Krause wrote:
> >> >> On March 23, 2015 6:40:06 AM EDT, Dan Carpenter
> >> ><dan.carpenter@...cle.com> wrote:
> >> >> >On Sun, Mar 22, 2015 at 08:04:35PM -0400, Nicholas Krause wrote:
> >> >> >> Fixes the checkpath.pl error where the opening bracket has a
> >> >unneeded
> >> >> >space between
> >> >> >> it and the function name for a if statement in the
> >> >> >marco,VMX_WAIT_FOR_FIELD32.
> >> >> >> 
> >> >> >> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> >> >> >> ---
> >> >> >>  drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> >> >> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >> >> 
> >> >> >> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
> >> >> >b/drivers/staging/octeon-usb/octeon-hcd.c
> >> >> >> index 1daeb31..0408a12 100644
> >> >> >> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> >> >> >> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> >> >> >> @@ -412,7 +412,7 @@ struct octeon_hcd {
> >> >> >>  		type c;							    \
> >> >> >>  		while (1) {						    \
> >> >> >>  			c.u32 = __cvmx_usb_read_csr32(usb, address);	    \
> >> >> >> -			if (c.s.field op (value)) {			    \
> >> >> >> +			if (c.s.field op(value)) {			    \
> >> >> >
> >> >> >"op" is not a function here.  This is macro and top is an
> >operation
> >> >> >like
> >> >> >"+" or "*".  So checkpatch.pl is wrong.
> >> >> >
> >> >> >regards,
> >> >> >dan carpenter
> >> >> Very well then, I wasn't sure if we did the  same spacing style
> >for
> >> >marcos. 
> >> >
> >> >We do but this is a very unusual case.
> >> >
> >> >regards,
> >> >dan carpenter
> >> Dan,  
> >> Sorry about that my mistake.  In addition, have you looked at my
> >second patch to see if that one is correct. 
> >
> >Yes.  That one is fine.
> >
> >regards,
> >dan carpenter
> Dan, 
> Just one more question, is that patch going to be merged or should I resubmit 
> it as a series of one patch?

Someone else already sent the same patch that got applied:

https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/drivers/staging/octeon-usb?h=staging-testing&id=877945759df5ff6e7fb434cb5b6cddb606c2f66f

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/