linux-kernel - Re: [PATCH v3] kprobes: Disable Kprobe when ftrace arming fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150324075925.GH4500@dhcp128.suse.cz>
Date:	Tue, 24 Mar 2015 08:59:25 +0100
From:	Petr Mladek <pmladek@...e.cz>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	"David S. Miller" <davem@...emloft.net>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
	Ananth NMavinakayanahalli <ananth@...ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] kprobes: Disable Kprobe when ftrace arming fails

On Mon 2015-03-23 23:36:00, Jiri Kosina wrote:
> On Mon, 23 Mar 2015, Ingo Molnar wrote:
> 
> > > > > wth is a 'universe' in this context?
> > > > 
> > > > We use the term "universe" to define whether the system or task uses
> > > > original or patched functions. It is especially important for patches
> > > > that modify semantic of functions. They need more complex consistency
> > > > model. It defines when it is safe time for the system or task to start
> > > > using the new functions (switch to the new universe).
> > > > 
> > > > In theory, different tasks might be in more universes if more patches are
> > > > being applied. In practice, we deal with only two universes. The trick is
> > > > that we allow to add new patch only when the whole system has switched
> > > > to the previous one.
> > > > 
> > > 
> > > Is this terminology documented anywhere upstream yet?
> > 
> > Even if it was documented (it isn't), 
> 
> There is no point in documenting it upstream, as no upstream code is using 
> this "universe" notation. It should just be removed from original Petr's 
> changelog and that's it.

Note that the term "universe" is not used in the commit message => no
change is needed.

I used the term to answer the question about interference between
Jprobes, ftrace, and live patches. I am sorry again. I should have
described it in a broader context.


Anyway, please, let me to repeat. This patch makes sense even without
live patching. The ftrace operations were there even before and might
have failed.

Best Regards,
Petr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/