linux-kernel - Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Mar 2015 11:37:38 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Robert Dolca <robert.dolca@...el.com>
Cc:	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Jonathan Cameron <jic23@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Denis CIOCCA <denis.ciocca@...com>
Subject: Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

On Mon, Mar 23, 2015 at 2:40 PM, Robert Dolca <robert.dolca@...el.com> wrote:

> Signed-off-by: Robert Dolca <robert.dolca@...el.com>

More comments...

> +static const char L3G4200D_gyro_dev_name[]  = "l3g4200d";
> +static const char LSM330D_gyro_dev_name[]   = "lsm330d_gyro";
> +static const char LSM330DL_gyro_dev_name[]  = "lsm330dl_gyro";
> +static const char LSM330DLC_gyro_dev_name[] = "lsm330dlc_gyro";
> +static const char L3GD20_gyro_dev_name[]    = "l3gd20";
> +static const char L3G4IS_gyro_dev_name[]    = "l3g4is_ui";
> +static const char LSM330_gyro_dev_name[]    = "lsm330_gyro";

Look here:
drivers/iio/gyro/st_gyro.h

#define L3G4200D_GYRO_DEV_NAME          "l3g4200d"
#define LSM330D_GYRO_DEV_NAME           "lsm330d_gyro"
#define LSM330DL_GYRO_DEV_NAME          "lsm330dl_gyro"
#define LSM330DLC_GYRO_DEV_NAME         "lsm330dlc_gyro"
#define L3GD20_GYRO_DEV_NAME            "l3gd20"
#define L3G4IS_GYRO_DEV_NAME            "l3g4is_ui"
#define LSM330_GYRO_DEV_NAME            "lsm330_gyro"

Don't redo these definitons, use the defines from the header file.
The DT table uses them.

Atleast do:
static const char L3G4200D_gyro_dev_name[]  = L3G4200D_GYRO_DEV_NAME;

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/