lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Mar 2015 18:42:50 +0800 From: Fam Zheng <famz@...hat.com> To: Paolo Bonzini <pbonzini@...hat.com> Cc: linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>, "James E.J. Bottomley" <JBottomley@...allels.com>, linux-scsi@...r.kernel.org Subject: Re: [PATCH 0/3] Fix return code for ioctl( BLKRRPART ) if device is down On Tue, 03/24 11:34, Paolo Bonzini wrote: > > > On 24/03/2015 11:16, Fam Zheng wrote: > > If issued right after link down, "blockdev --rereadpt" will be stuck for a > > while and then return normally. Although the underlying capacity and partition > > table are not correctly updated. And it means that userspace can't detect the > > error at all. > > > > Fix this by propargating the error of "read capacity" command through the > > stack, so that the ioctl could fail with -EIO. > > > > Fam Zheng (3): > > block: Return error in rescan_partitions if revalidating disk failed > > sd: Return error in sd_revalidate_disk if read capacity failed > > sd: Return -EIO if read capacity failed > > > > block/partition-generic.c | 6 +++--- > > drivers/scsi/sd.c | 22 +++++++++++++--------- > > 2 files changed, 16 insertions(+), 12 deletions(-) > > > > Reviewed-by: Paolo Bonzini <pbonzini@...hat.com> > > Though patch 3 could be seen as a change in userspace ABI, so I'm less > sure about it. > The changed -EINVAL's are not to userspace before this series, so I think it is OK. Thanks for reviewing. Fam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists