linux-kernel - Re: [PATCH v4 1/4] staging: unisys: remove unneeded comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150324123656.GA11812@sudip-PC>
Date:	Tue, 24 Mar 2015 18:06:56 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Benjamin Romer <benjamin.romer@...sys.com>,
	David Kershner <david.kershner@...sys.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, sparmaintainer@...sys.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/4] staging: unisys: remove unneeded comparison

On Tue, Mar 24, 2015 at 03:30:21PM +0300, Dan Carpenter wrote:
> On Tue, Mar 24, 2015 at 05:47:34PM +0530, Sudip Mukherjee wrote:
> > visorchipset_file_cleanup() is called from visorchipset_exit() which
> > is the module_exit function and this function is executing means
> > module_init succeeded, so registered will always be true at this time.
> > and majordev has also been initialized in the init function. hence
> > these comparisons will always be true.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> 
> This is a partial patch.  The "one thing per patch" means don't do half
> a thing per patch.
> 
> We now set "registered" but there are no users.
it is being removed separately in the 4/4 patch.
do you want that to be combined here in this patch?
but then won't that become 2 different changes in a single patch?
my message says we are removing that as the comparison is always
true.

regards
sudip
> 
> regards,
> dan carpenter
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/