linux-kernel - Re: [PATCH 2/2] regulator: max8660: Add error message for missing regulator data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150324123809.GA8766@katana>
Date:	Tue, 24 Mar 2015 13:38:09 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Markus Pargmann <mpa@...gutronix.de>
Cc:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] regulator: max8660: Add error message for missing
 regulator data


>  	for (i = 0; i < pdata->num_subdevs; i++) {
> -		if (!pdata->subdevs[i].platform_data)
> +		if (!pdata->subdevs[i].platform_data) {
> +			dev_err(dev, "No data for %d regulator\n", i);
>  			return -EINVAL;
> +		}

I'd rather save the string and go for -ENOENT instead. But I don't mind
much...


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)