linux-kernel - Re: [PATCH 1/5] mfd: arizona: Add missing gpio_free in arizona_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150324160642.GE17265@sirena.org.uk>
Date:	Tue, 24 Mar 2015 09:06:43 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	lee.jones@...aro.org, sameo@...ux.intel.com,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] mfd: arizona: Add missing gpio_free in
 arizona_dev_exit

On Tue, Mar 24, 2015 at 02:59:48PM +0000, Charles Keepax wrote:

> -	if (arizona->pdata.reset)
> +	if (arizona->pdata.reset) {
>  		gpio_set_value_cansleep(arizona->pdata.reset, 0);
> +		gpio_free(arizona->pdata.reset);
> +	}

Or acquire the GPIO with devm_ and avoid having to explicitly free it at
all?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)