linux-kernel - Re: [PATCH 1/5] mfd: arizona: Add missing gpio_free in arizona_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150324165144.GJ23705@opensource.wolfsonmicro.com>
Date:	Tue, 24 Mar 2015 16:51:44 +0000
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	lee.jones@...aro.org, sameo@...ux.intel.com,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] mfd: arizona: Add missing gpio_free in
	arizona_dev_exit

On Tue, Mar 24, 2015 at 09:06:43AM -0700, Mark Brown wrote:
> On Tue, Mar 24, 2015 at 02:59:48PM +0000, Charles Keepax wrote:
> 
> > -	if (arizona->pdata.reset)
> > +	if (arizona->pdata.reset) {
> >  		gpio_set_value_cansleep(arizona->pdata.reset, 0);
> > +		gpio_free(arizona->pdata.reset);
> > +	}
> 
> Or acquire the GPIO with devm_ and avoid having to explicitly free it at
> all?

Ooops... yeah will respin for that.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/