linux-kernel - Re: [PATCH 1/2] regulator: max8660: Remove boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150324162226.GG17265@sirena.org.uk>
Date:	Tue, 24 Mar 2015 09:22:27 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Markus Pargmann <mpa@...gutronix.de>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Wolfram Sang <wsa@...-dreams.de>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] regulator: max8660: Remove boot_on handling

On Tue, Mar 24, 2015 at 01:08:02PM +0100, Markus Pargmann wrote:

> boot_on is handled by the regulator core. It will call enable() on the
> regulators that are specified to be boot_on. So we don't require any
> additional handling in this driver

>  		switch (pdata->subdevs[i].id) {
>  		case MAX8660_V3:
> -			if (boot_on)
> -				max8660->shadow_regs[MAX8660_OVER1] |= 1;
> -			break;
> -

So, this is updating the register default value rather than writing to
the device.  That suggests that the purpose is to either avoid needless
write outs to the device or something, or at the very least it's not a
completely direct reimplementation of the core functionality.  It is
certainly underdocumented at the minute (and the driver probably wants
to be converted to regmap) but this makes me a bit cautious about
obvious cleanups missing something.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)