lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Mar 2015 16:22:19 +0000 From: Dietmar Eggemann <dietmar.eggemann@....com> To: Peter Zijlstra <peterz@...radead.org>, Morten Rasmussen <Morten.Rasmussen@....com> CC: "mingo@...hat.com" <mingo@...hat.com>, "vincent.guittot@...aro.org" <vincent.guittot@...aro.org>, "yuyang.du@...el.com" <yuyang.du@...el.com>, "preeti@...ux.vnet.ibm.com" <preeti@...ux.vnet.ibm.com>, "mturquette@...aro.org" <mturquette@...aro.org>, "nico@...aro.org" <nico@...aro.org>, "rjw@...ysocki.net" <rjw@...ysocki.net>, Juri Lelli <Juri.Lelli@....com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [RFCv3 PATCH 38/48] sched: Infrastructure to query if load balancing is energy-aware On 24/03/15 13:56, Peter Zijlstra wrote: > On Wed, Feb 04, 2015 at 06:31:15PM +0000, Morten Rasmussen wrote: >> From: Dietmar Eggemann <dietmar.eggemann@....com> >> >> Energy-aware load balancing should only happen if the ENERGY_AWARE feature >> is turned on and the sched domain on which the load balancing is performed >> on contains energy data. >> There is also a need during a load balance action to be able to query if we >> should continue to load balance energy-aware or if we reached the tipping >> point which forces us to fall back to the conventional load balancing >> functionality. > >> @@ -7348,6 +7349,7 @@ static int load_balance(int this_cpu, struct rq *this_rq, >> .cpus = cpus, >> .fbq_type = all, >> .tasks = LIST_HEAD_INIT(env.tasks), >> + .use_ea = (energy_aware() && sd->groups->sge) ? true : false, > > fwiw, no tipping point in that logic. Wanted to explain why I added lv_env::use_ea. But mentioning the tipping point problem here seems to be a little far-fetched. Will get rid of the second sentence in the header. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists