linux-kernel - Re: [PATCH] pci: iproc: fix PCIE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo6MPw7m-zJbCAxGAaRm7jptpaJ-937A6qNXELNTggf9ZA@mail.gmail.com>
Date:	Tue, 24 Mar 2015 19:28:20 -0500
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Ray Jui <rjui@...adcom.com>
Cc:	Scott Branden <sbranden@...adcom.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH] pci: iproc: fix PCIE_IPROC in Kconfig

On Tue, Mar 24, 2015 at 12:33 AM, Ray Jui <rjui@...adcom.com> wrote:
> Make PCIE_IPROC depending on both OF and ARM and default to be disabled,
> so it cannot be accidentally enabled by other platforms
>
> PCIE_IPROC is meant to be enabled by a front-end bus driver. Curenntly
> it's enabled by PCIE_IPROC_PLTFM driver
>
> Signed-off-by: Ray Jui <rjui@...adcom.com>
> ---
>  drivers/pci/host/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index feccd0d..963b507 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -108,6 +108,8 @@ config PCI_VERSATILE
>
>  config PCIE_IPROC
>         tristate "Broadcom iProc PCIe controller"
> +       depends on OF && ARM
> +       default n
>         help
>           This enables the iProc PCIe core controller support for Broadcom's
>           iProc family of SoCs. An appropriate bus interface driver also needs

What pattern are you following?  There must be other drivers with
similar front-end bus driver schemes, and I'd rather copy their
Kconfig descriptions than invent something new.

With CONFIG_PCIE_IPROC_PLTFM, can we spell out "PLATFORM"?  Doesn't
seem like there's anything to gain by abbreviating it.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/