linux-kernel - Re: [PATCH] staging: rtl8723au: Update RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wrfjegodj4xj.fsf@redhat.com>
Date:	Tue, 24 Mar 2015 20:28:56 -0400
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8723au: Update RT_TRACE macro and uses

Joe Perches <joe@...ches.com> writes:
> Create an rt_trace function using %pV to reduce overall code size.
> Update the macro uses to remove unnecessary and now harmful parentheses.
>
> Miscellanea around these changes:
>
> o Coalesce formats
> o Realign arguments
> o Remove commented-out RT_TRACE uses
> o Spelling fixes in formats
> o Add missing newlines to formats
> o Remove multiple newlines from formats
> o Neaten formats where noticed
> o Use %pM in one instance
>
> Reduces code size ~20KB
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
> Mostly done by various scripts&emacs.
> Compiled, untested, no hardware,

This could be further improved by fixing up all the places where the
function name is hard coded into the print statement, instead of using
__func__. In particular as a lot of it is carried over from old code
and has been renamed since.

It's OK with me to do this in a follow-on patch though.

Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/