linux-kernel - Re: [PATCH v3] led/led-class: Handle LEDs with the same name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Mar 2015 10:20:59 +0100
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Sakari Ailus <sakari.ailus@....fi>
Cc:	Bryan Wu <cooloney@...il.com>, Richard Purdie <rpurdie@...ys.net>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, j.anaszewski@...sung.com
Subject: Re: [PATCH v3] led/led-class: Handle LEDs with the same name

Hi Sakari

On Wed, Mar 25, 2015 at 1:54 AM, Sakari Ailus <sakari.ailus@....fi> wrote:
> I'd use dev_warn() or even WARN_ON(ret). This is a rather serious issue as
> now the probe order defines the name of the device. There might be something
> better such as the I2C bus/address.

I have no problem in sending a dev_warn, WARN_ON looks too much to me.

In my example (dt overlays), it is perfectly ok to have duplicated names.

>
> If the registration order for some reason changes, that'd revert the device
> names. In Media controller this is part of the user space API.

Would it be possible for media controller leds to have a name based on
their address?


Regarding s/dev_info/dev_warn : Do you want to send the patch or I should do it?

Regards!

-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/