linux-kernel - Re: [PATCH v3] led/led-class: Handle LEDs with the same name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150325130243.GL18321@valkosipuli.retiisi.org.uk>
Date:	Wed, 25 Mar 2015 15:02:43 +0200
From:	Sakari Ailus <sakari.ailus@....fi>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc:	Bryan Wu <cooloney@...il.com>, Richard Purdie <rpurdie@...ys.net>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, j.anaszewski@...sung.com
Subject: Re: [PATCH v3] led/led-class: Handle LEDs with the same name

Hi Ricardo,

On Wed, Mar 25, 2015 at 10:20:59AM +0100, Ricardo Ribalda Delgado wrote:
> Hi Sakari
> 
> On Wed, Mar 25, 2015 at 1:54 AM, Sakari Ailus <sakari.ailus@....fi> wrote:
> > I'd use dev_warn() or even WARN_ON(ret). This is a rather serious issue as
> > now the probe order defines the name of the device. There might be something
> > better such as the I2C bus/address.
> 
> I have no problem in sending a dev_warn, WARN_ON looks too much to me.
> 
> In my example (dt overlays), it is perfectly ok to have duplicated names.
> 
> >
> > If the registration order for some reason changes, that'd revert the device
> > names. In Media controller this is part of the user space API.
> 
> Would it be possible for media controller leds to have a name based on
> their address?

It's included where there's a stable address. That's not true for GPIO
controlled devices though, it's a GPIO controller plus a number. Ramming
lots of information to the media entity's name field is not possible since
it's just 32 bytes; for this reason we're looking to implement a better way
to recognise devices in MC. But for now, we got to cope with what we have.

> Regarding s/dev_info/dev_warn : Do you want to send the patch or I should do it?

Is this one merged already? If yes, sure I can. Otherwise a new version
would be nice.

-- 
Cheers,

Sakari Ailus
e-mail: sakari.ailus@....fi	XMPP: sailus@...iisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/