linux-kernel - Re: [PATCHv2] pcmcia:Fix memory leak in the function, sa11xx_drv_pcmcia

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150326095225.GY8656@n2100.arm.linux.org.uk>
Date:	Thu, 26 Mar 2015 09:52:25 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	dbaryshkov@...il.com, linux-pcmcia@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] pcmcia:Fix memory leak in the function,
 sa11xx_drv_pcmcia_probe

On Wed, Mar 25, 2015 at 11:15:52PM -0400, Nicholas Krause wrote:
> This fixes the memory found when running  coccinelle on the latest

How does this "fix the memory" ?  Is the memory faulty?

> kernel tree for if we are unable to successfully allocate memory
> for the structure pointer,sinfo of type skt_dev_info and need to
> clean up the memory already allocated to the clk structure pointer,
> clk by calling clk_get on it and freeing the no longer required
> mermory for this structure pointer.

This makes no sense.  clk_get() itself doesn't allocate any memory.  As
usual, you act as a mechanical automatom which doesn't understand what
you're doing or you just guess.  I don't care which it is, you are a
danger to the kernel by doing this.  As many other experienced kernel
developers have told you, please stop.

In any case, I'm NAKing your patch as there's better ways to solve this.
That's where experience and research come in.

Nevertheless, thanks for pointing out the oversight, and I notice that
there are a few more cases too.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/