linux-kernel - Re: [PATCH 2/3] clocksource: mips-gic-timer: Ensure GIC counter is running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5513D6E4.4000101@linaro.org>
Date:	Thu, 26 Mar 2015 10:52:36 +0100
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Markos Chandras <markos.chandras@...tec.com>,
	linux-mips@...ux-mips.org
CC:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] clocksource: mips-gic-timer: Ensure GIC counter is
 running

On 03/23/2015 01:32 PM, Markos Chandras wrote:
> Start the GIC counter after configuring the clocksource since there
> are no guarantees the counter will be running after a CPU reset.
>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: <linux-kernel@...r.kernel.org>
> Signed-off-by: Markos Chandras <markos.chandras@...tec.com>

Acked-by: Daniel Lezcano <daniel.lezcano@...aro.org>

> ---
>   drivers/clocksource/mips-gic-timer.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clocksource/mips-gic-timer.c b/drivers/clocksource/mips-gic-timer.c
> index 3bd31b1321f6..16adbc1fa4c1 100644
> --- a/drivers/clocksource/mips-gic-timer.c
> +++ b/drivers/clocksource/mips-gic-timer.c
> @@ -133,6 +133,9 @@ static void __init __gic_clocksource_init(void)
>   	clocksource_register_hz(&gic_clocksource, gic_frequency);
>
>   	gic_clockevent_init();
> +
> +	/* And finally start the counter */
> +	gic_start_count();
>   }
>
>   void __init gic_clocksource_init(unsigned int frequency)
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/