linux-kernel - Re: [PATCH v2 4/7] dmaengine: omap-dma: Use defines for dma channels and request count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150326105712.GL32683@intel.com>
Date:	Thu, 26 Mar 2015 16:27:12 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	tony@...mide.com, linux@....linux.org.uk, grant.likely@...aro.org,
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, robh+dt@...nel.org, nm@...com
Subject: Re: [PATCH v2 4/7] dmaengine: omap-dma: Use defines for dma channels
 and request count

On Wed, Mar 11, 2015 at 03:23:27PM +0200, Peter Ujfalusi wrote:
> Instead of magic numbers in the code, use define for number of logical DMA
> channels and DMA requests.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---
>  drivers/dma/omap-dma.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
> index 7dd6dd121681..56c33e93dd24 100644
> --- a/drivers/dma/omap-dma.c
> +++ b/drivers/dma/omap-dma.c
> @@ -22,6 +22,9 @@
>  
>  #include "virt-dma.h"
>  
> +#define OMAP_SDMA_REQUESTS	127
> +#define OMAP_SDMA_CHANNELS	32
Again why dont we put these things in DT ?

-- 
~Vinod
> +
>  struct omap_dmadev {
>  	struct dma_device ddev;
>  	spinlock_t lock;
> @@ -33,7 +36,7 @@ struct omap_dmadev {
>  	bool legacy;
>  	spinlock_t irq_lock;
>  	uint32_t irq_enable_mask;
> -	struct omap_chan *lch_map[32];
> +	struct omap_chan *lch_map[OMAP_SDMA_CHANNELS];
>  };
>  
>  struct omap_chan {
> @@ -1115,7 +1118,7 @@ static int omap_dma_probe(struct platform_device *pdev)
>  
>  	tasklet_init(&od->task, omap_dma_sched, (unsigned long)od);
>  
> -	for (i = 0; i < 127; i++) {
> +	for (i = 0; i < OMAP_SDMA_REQUESTS; i++) {
>  		rc = omap_dma_chan_init(od, i);
>  		if (rc) {
>  			omap_dma_free(od);
> -- 
> 2.3.0
> 

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/