linux-kernel - Re: [PATCH 10/11] clocksource: flexcard: Add basic timestamp counter support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5513E71E.3090501@linutronix.de>
Date:	Thu, 26 Mar 2015 12:01:50 +0100
From:	Holger Dengler <dengler@...utronix.de>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	linux-kernel@...r.kernel.org
CC:	Peter Mahler <mahler@...ug.com>, Juergen Bubeck <bubeck@...ug.com>,
	Benedikt Spranger <b.spranger@...utronix.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	John Stultz <john.stultz@...aro.org>
Subject: Re: [PATCH 10/11] clocksource: flexcard: Add basic timestamp counter
 support

Hi Daniel,

On 03/26/2015 10:41 AM, Daniel Lezcano wrote:
>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>> index 68161f7..a6b9308 100644
>> --- a/drivers/clocksource/Kconfig
>> +++ b/drivers/clocksource/Kconfig
>> @@ -250,4 +250,15 @@ config CLKSRC_PXA
>>       help
>>         This enables OST0 support available on PXA and SA-11x0
>>         platforms.
>> +
>> +config CLKSRC_FLEXCARD
>> +    tristate "Support for Flexcard clock function"
> 
> Why do you need this to be a module ?
> 
> The Kconfig policy is to have it selected by the arch Kconfig.
> 
> It should be like:
> 
> config CLKSRC_FLEXCARD
>     bool
>     select CLKSRC_MMIO

The Flexcard PMC II, which provides this clocksrc functionality, is a
PCI card. According to the PMC specs, this card-type is hot-plugable. So
this clocksrc is not SoC-related, it's also hot-plugable.
Therefore a module-capable driver seems a good solution for me.

> 
> and then the Kconfig for MFD_FLEXCARD selects CLKSRC_FLEXCARD.
> 

Ok, this could be an option to enable the clocksrc feature by default,
if MFD_FLEXCARD is selected.

>> +    depends on MFD_FLEXCARD
>> +    select CLKSRC_MMIO
>> +    help
>> +      This is the clocksource function driver for the
>> +      Eberspaecher Flexcard PMC II carrier board. The
>> +      Flexcard provide a Flexray synchronized counter
>> +      configurable at 1, 10 or 100MHz.
>> +
>>   endmenu

-- 
Kind regards,
Holger Dengler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/