linux-kernel - Re: [PATCH 10/11] clocksource: flexcard: Add basic timestamp counter support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLV-hS4UZ=fNZqZNXzmqmYGWoZuG3_281nAo3W=7j2rUKg@mail.gmail.com>
Date:	Thu, 26 Mar 2015 09:34:59 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Holger Dengler <dengler@...utronix.de>
Cc:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Peter Mahler <mahler@...ug.com>,
	Juergen Bubeck <bubeck@...ug.com>,
	Benedikt Spranger <b.spranger@...utronix.de>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 10/11] clocksource: flexcard: Add basic timestamp counter support

On Thu, Mar 26, 2015 at 4:01 AM, Holger Dengler <dengler@...utronix.de> wrote:
> On 03/26/2015 10:41 AM, Daniel Lezcano wrote:
>>
>> config CLKSRC_FLEXCARD
>>     bool
>>     select CLKSRC_MMIO
>
> The Flexcard PMC II, which provides this clocksrc functionality, is a
> PCI card. According to the PMC specs, this card-type is hot-plugable. So
> this clocksrc is not SoC-related, it's also hot-plugable.
> Therefore a module-capable driver seems a good solution for me.
>
>>
>> and then the Kconfig for MFD_FLEXCARD selects CLKSRC_FLEXCARD.
>>
>
> Ok, this could be an option to enable the clocksrc feature by default,
> if MFD_FLEXCARD is selected.

Yea, I think this would be preferred. If the user already selects
something to get device functionality, lets not make them search
around in other menus to find another config option to enable all the
capabilities.

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/