lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150327121058.GA15631@gmail.com>
Date:	Fri, 27 Mar 2015 13:10:58 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Bandan Das <bsd@...hat.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/apic: remove read/write test in verify_local_apic()


* Bandan Das <bsd@...hat.com> wrote:

> 
> Most newer processors have the APIC_ID read-only and this
> test probably fails on most boxes anyway. Fix typos.
> 
> Signed-off-by: Bandan Das <bsd@...hat.com>
> ---
> Honestly, I don't think this function is really needed.
> It's called for both UP/MP but the return value isn't
> used by any of them. Maybe, we should just remove it ?

Agreed, lets just remove it.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ