linux-kernel - Re: [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast() and, cap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuTgQUKMYOE7XBxUPG=amYi1zSJ-7FVk92uf4pVbGimtymXMw@mail.gmail.com>
Date:	Fri, 27 Mar 2015 19:09:27 +0100
From:	Yun Wang <yun.wang@...fitbricks.com>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:	"ira.weiny" <ira.weiny@...el.com>,
	Roland Dreier <roland@...nel.org>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-nfs@...r.kernel.org, netdev@...r.kernel.org,
	"J. Bruce Fields" <bfields@...ldses.org>,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	"David S. Miller" <davem@...emloft.net>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Moni Shoua <monis@...lanox.com>,
	PJ Waskiewicz <pj.waskiewicz@...idfire.com>,
	Tatyana Nikolova <Tatyana.E.Nikolova@...el.com>,
	Yan Burman <yanb@...lanox.com>,
	Jack Morgenstein <jackm@....mellanox.co.il>,
	Bart Van Assche <bvanassche@....org>,
	Yann Droneaud <ydroneaud@...eya.com>,
	Colin Ian King <colin.king@...onical.com>,
	Majd Dibbiny <majd@...lanox.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Matan Barak <matanb@...lanox.com>,
	Alex Estrin <alex.estrin@...el.com>,
	Doug Ledford <dledford@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Erez Shitrit <erezsh@...lanox.com>,
	Sagi Grimberg <sagig@...lanox.com>,
	Haggai Eran <haggaie@...lanox.com>,
	Shachar Raindel <raindel@...lanox.com>,
	Mike Marciniszyn <mike.marciniszyn@...el.com>,
	Steve Wise <swise@...ngridcomputing.com>,
	Tom Tucker <tom@....us>, Chuck Lever <chuck.lever@...cle.com>
Subject: Re: [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast()
 and, cap_mcast() for mcast-check

On Fri, Mar 27, 2015 at 6:49 PM, Jason Gunthorpe
<jgunthorpe@...idianresearch.com> wrote:
> On Fri, Mar 27, 2015 at 06:31:26PM +0100, Yun Wang wrote:
>
>> Maybe we can temporarily reserve the old logical, and gradually solve
>> these problems?
>
> It is best to make behavioral changes in small patches, yes.
>
> I think it is best to address these sorts of problems before trying to
> tackle the driver interface side - that will avoid complexity.
>
> ie how does a driver set has_ipoib? It isn't even a sensible question
> when it is a per port capability.

I used to imaging it would like:

init_device_mgmt_attributs(device)
{
    for_each_port(device)
        if (port support XX) {
            port.mgmt_attribute |= CAP_XX
             if !(device.mgmt_attribute & HAS_XX)
                 device.mgmt_attribute |= HAS_XX
        }
}

That is incase if a device got one port have some capability, the
device have it too, so has_XX() will check on device level that if it
has any port support XX, and cap_XX() to check on port level.

But if has_XX() is only for optimizing the init/exit path, then it
doesn't make sense to me any more...

Regards,
Michael Wang

>
> Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/