linux-kernel - Re: [PATCH] dmaengine: pl330: fix the race condition in pl330 driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABb+yY3s8ZXWe3YAsEeKZ6Vx2av2yvdjWiBGiy7_uGCcai=Rpw@mail.gmail.com>
Date:	Mon, 30 Mar 2015 22:17:17 +0530
From:	Jassi Brar <jassisinghbrar@...il.com>
To:	Scott Branden <sbranden@...adcom.com>
Cc:	Dan Williams <dan.j.williams@...el.com>,
	Vinod Koul <vinod.koul@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	ismail <ismail@...adcom.com>, Anatol Pomazao <anatol@...gle.com>,
	Dmitry Torokhov <dtor@...gle.com>,
	bcm-kernel-feedback-list@...adcom.com,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] dmaengine: pl330: fix the race condition in pl330 driver.

On Fri, Mar 27, 2015 at 5:25 AM, Scott Branden <sbranden@...adcom.com> wrote:
> From: ismail <ismail@...adcom.com>
>
> Update the thread running index before issuing the
> GO command to the DMAC.
>
> Tested-by: Mohamed Ismail Abdul Packir Mohamed <ismail@...adcom.com>
> Reviewed-by: Ray Jui <rjui@...adcom.com>
> Reviewed-by: Arun Parameswaran <aparames@...adcom.com>
> Reviewed-by: Scott Branden <sbranden@...adcom.com>
> Signed-off-by: Scott Branden <sbranden@...adcom.com>
> Signed-off-by: Mohamed Ismail Abdul Packir Mohamed <ismail@...adcom.com>
> ---
>  drivers/dma/pl330.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index 0e1f567..631642d 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -1072,11 +1072,11 @@ static bool _trigger(struct pl330_thread *thrd)
>         /* Set to generate interrupts for SEV */
>         writel(readl(regs + INTEN) | (1 << thrd->ev), regs + INTEN);
>
> +       thrd->req_running = idx;
> +
>         /* Only manager can execute GO */
>         _execute_DBGINSN(thrd, insn, true);
>
> -       thrd->req_running = idx;
> -
It would help to know what the behavior looks like before and after
the patch. If anything we should look at locking rather the
reordering.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/