linux-kernel - Re: [PATCH] mm/memblock: add debug output for the memblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150331163808.6ffa50f3140b50828bd5dba8@linux-foundation.org>
Date:	Tue, 31 Mar 2015 16:38:08 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Philipp Hachtmann <phacht@...ux.vnet.ibm.com>,
	Fabian Frederick <fabf@...net.be>,
	Catalin Marinas <catalin.marinas@....com>,
	Emil Medve <Emilian.Medve@...escale.com>,
	Akinobu Mita <akinobu.mita@...il.com>,
	Tang Chen <tangchen@...fujitsu.com>,
	Tony Luck <tony.luck@...el.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/memblock: add debug output for the memblock_add

On Sat, 28 Mar 2015 23:08:03 +0600 Alexander Kuleshov <kuleshovmail@...il.com> wrote:

> memblock_reserve function calls memblock_reserve_region which
> prints debugging information if 'memblock=debug' passed to the
> command line. This patch adds the same behaviour, but for the 
> memblock_add function.
> 
> Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
> ---
>  mm/memblock.c | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 252b77b..c7b8306 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -580,10 +580,24 @@ int __init_memblock memblock_add_node(phys_addr_t base, phys_addr_t size,
>  	return memblock_add_range(&memblock.memory, base, size, nid, 0);
>  }
>  
> +static int __init_memblock memblock_add_region(phys_addr_t base,
> +						phys_addr_t size,
> +						int nid,
> +						unsigned long flags)
> +{
> +	struct memblock_type *_rgn = &memblock.memory;
> +
> +	memblock_dbg("memblock_memory: [%#016llx-%#016llx] flags %#02lx %pF\n",

I guess this should be "memblock_add:".  That's what
memblock_reserve_region() does?

--- a/mm/memblock.c~mm-memblock-add-debug-output-for-the-memblock_add-fix
+++ a/mm/memblock.c
@@ -587,7 +587,7 @@ static int __init_memblock memblock_add_
 {
 	struct memblock_type *_rgn = &memblock.memory;
 
-	memblock_dbg("memblock_memory: [%#016llx-%#016llx] flags %#02lx %pF\n",
+	memblock_dbg("memblock_add: [%#016llx-%#016llx] flags %#02lx %pF\n",
 		     (unsigned long long)base,
 		     (unsigned long long)base + size - 1,
 		     flags, (void *)_RET_IP_);
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/