linux-kernel - Re: [PATCH 05/12] HID: hid-lg4ff: Update a warning message for a case where device is incorrectly flagged to be handled by hid-lg4ff in hid-lg.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1503311638080.21441@pobox.suse.cz>
Date:	Tue, 31 Mar 2015 16:38:38 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Michal Malý <madcatxster@...oid-pointer.net>
cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	elias.vds@...il.com, simon@...gewell.org
Subject: Re: [PATCH 05/12] HID: hid-lg4ff: Update a warning message for a
 case where device is incorrectly flagged to be handled by hid-lg4ff in
 hid-lg.

On Sat, 21 Mar 2015, Michal Malý wrote:

> The original warning message was highly misleading. This warning can be
> triggered only if a device is flagged to be handled by hid-lg4ff in
> hid-lg but hid-lg4ff lacks support for such device.
> 
> Signed-off-by: Michal Malý <madcatxster@...oid-pointer.net>
> ---
>  drivers/hid/hid-lg4ff.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
> index d1d5d45..a2f47ee 100644
> --- a/drivers/hid/hid-lg4ff.c
> +++ b/drivers/hid/hid-lg4ff.c
> @@ -1021,8 +1021,7 @@ int lg4ff_init(struct hid_device *hid)
>  	}
>  
>  	if (i == ARRAY_SIZE(lg4ff_devices)) {
> -		hid_err(hid, "Device is not supported by lg4ff driver. If you think it should be, consider reporting a bug to"
> -			     "LKML, Simon Wood <simon@...gewell.org> or Michal Maly <madcatxster@...il.com>\n");
> +		hid_err(hid, "This device is flagged to be handled by the lg4ff module but this module does not know how to handle it. Please report this as a bug to LKML, Simon Wood <simon@...gewell.org> or Michal Maly <madcatxster@...oid-pointer.net>\n");

Could you please split this so that we don't have this ugly overly long 
line, and resend this patch as v2? Thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/