linux-kernel - Re: [PATCH 07/12] HID: hid-lg4ff: Protect concurrent access to the output HID report values with a spinlock.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 31 Mar 2015 16:44:17 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Michal Malý <madcatxster@...oid-pointer.net>
cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	elias.vds@...il.com, simon@...gewell.org
Subject: Re: [PATCH 07/12] HID: hid-lg4ff: Protect concurrent access to the
 output HID report values with a spinlock.

On Sat, 21 Mar 2015, Michal Malý wrote:

> Since all functions that need to send some data to the device they
> manage share the same HID report some synchronization is needed to
> prevent sending bogus data to the device.

This patch is doing much more than just adding a mutual exclusion 
mechanisms (for example the wdata indirection), so more descriptive 
changelog is needed.

Looking at the patch it's actually not clear at all what are all the 
things it's trying to do, so please resend v2 of this patch with much more 
verbose changelog, so that I am able to review it properly. Thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/