linux-kernel - Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150401090520.559ead39@linux.lan.towertech.it>
Date:	Wed, 1 Apr 2015 09:05:20 +0200
From:	Alessandro Zummo <a.zummo@...ertech.it>
To:	Joe Perches <joe@...ches.com>
Cc:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in
 the error log

On Tue, 31 Mar 2015 20:18:28 -0700
Joe Perches <joe@...ches.com> wrote:

> Neither __func__ or __FILE__ is really useful here.
> The message is already specific enough without it.
> 
> If anything, it'd probably be better to add
> 
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

 Seems reasonable given that pr_fmt is widely
 used elsewhere.

 I don't like too much the need to have one define for
 each file, but it's the way it works :-/

-- 

 Best regards,

 Alessandro Zummo - CEO,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/