linux-kernel - Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427872512.31790.3.camel@perches.com>
Date:	Wed, 01 Apr 2015 00:15:12 -0700
From:	Joe Perches <joe@...ches.com>
To:	Alessandro Zummo <a.zummo@...ertech.it>
Cc:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in
 the error log

On Wed, 2015-04-01 at 09:05 +0200, Alessandro Zummo wrote:
> On Tue, 31 Mar 2015 20:18:28 -0700
> Joe Perches <joe@...ches.com> wrote:
> 
> > Neither __func__ or __FILE__ is really useful here.
> > The message is already specific enough without it.
> > 
> > If anything, it'd probably be better to add
> > 
> > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
>  Seems reasonable given that pr_fmt is widely
>  used elsewhere.
> 
>  I don't like too much the need to have one define for
>  each file, but it's the way it works :-/

True.  Right now.

I've a desire to make a change one day so that's
the default instead of blank.

http://comments.gmane.org/gmane.linux.kernel/1052288

There are some remaining treewide complications
before that can be done effectively though.

A few files will need "#define pr_fmt(fmt) fmt"
so no prefix is used.




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/