linux-kernel - Re: [PATCH v3 3/3] clk: qcom: Introduce parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <551C4B1C.6060804@linaro.org>
Date:	Wed, 01 Apr 2015 22:46:36 +0300
From:	Georgi Djakov <georgi.djakov@...aro.org>
To:	Hai Li <hali@...eaurora.org>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] clk: qcom: Introduce parent_map tables

On 1.04.15 17:22, Hai Li wrote:
> Hi Djakov,
> 
> Georgi Djakov <georgi.djakov <at> linaro.org> writes:
> 
>>
>> In the current parent mapping code, we can get duplicate or 
> inconsistent
>> indexes, which leads to discrepancy between the number of elements in 
> the
>> array and the number of parents. Until now, this was solved with some
>> reordering but this is not always possible.
>>
>> This patch introduces index tables that are used to define the 
> relations
>> between the PLL source and the hardware mux configuration value.
>> To accomplish this, here we do the following:
> 
> 
> There are other functions using f->src as index directly to find the 
> parent clock, at least the followings in file clk-rcg2.c:
> clk_pixel_determine_rate()
> _freq_tbl_determine_rate()
> clk_pixel_set_rate()
> clk_edp_pixel_determine_rate()
> clk_byte_determine_rate()
> 
> Shall we convert the index using qcom_find_src_index() at all these 
> places?
> 

Hi,
Yes, thanks for reporting this. I am working on a fix and trying
to verify it on all the platforms.

BR,
Georgi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/