linux-kernel - Re: [PATCH 2/3] staging: android: ion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150401222228.GF10964@mwanda>
Date:	Thu, 2 Apr 2015 01:22:28 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Phong Tran <tranmanphong@...il.com>
Cc:	gregkh@...uxfoundation.org, arve@...roid.com,
	riandrews@...roid.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] staging: android: ion_test: unregister the misc
 device

On Thu, Apr 02, 2015 at 12:38:19AM +0700, Phong Tran wrote:
> Add the remove() method for deregister from misc device
> when it's unloaded.
> 
> Signed-off-by: Phong Tran <tranmanphong@...il.com>
> ---
>  drivers/staging/android/ion/ion_test.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/staging/android/ion/ion_test.c b/drivers/staging/android/ion/ion_test.c
> index 3bc461c..f36a35e 100644
> --- a/drivers/staging/android/ion/ion_test.c
> +++ b/drivers/staging/android/ion/ion_test.c
> @@ -261,7 +261,25 @@ static int __init ion_test_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static int ion_test_remove(struct platform_device *pdev)
> +{
> +	int ret = 0;

Don't initialize variables if you don't need to.  Just remove the ret
variable completely.

> +	struct ion_test_device *testdev;
> +
> +	testdev = platform_get_drvdata(pdev);
> +
> +	if (!testdev) {

Remove the blank line between the function and the check.  They are part
of the same thing/paragraph.

> +		pr_err("failed to get pdev data.\n");

Just leave this error statement out.  It will never get printed.  It's
just a waste of RAM.  If it were printed the -ENODATA error is unique
to this path so it's all the debug out put we need.

> +		return -ENODATA;
> +	}
> +
> +	ret = misc_deregister(&testdev->misc);
> +
> +	return ret;
	return misc_deregister(&testdev->misc);

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/