linux-kernel - Re: [PATCH 21/21] time: Rework debugging variables so they aren't global

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150402083647.GT23123@twins.programming.kicks-ass.net>
Date:	Thu, 2 Apr 2015 10:36:47 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	John Stultz <john.stultz@...aro.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Prarit Bhargava <prarit@...hat.com>,
	Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH 21/21] time: Rework debugging variables so they aren't
 global

On Thu, Apr 02, 2015 at 09:51:51AM +0200, Ingo Molnar wrote:
> 
> * Peter Zijlstra <peterz@...radead.org> wrote:
> 
> > On Wed, Apr 01, 2015 at 08:34:41PM -0700, John Stultz wrote:
> > > Ingo suggested that the timekeeping debugging variables
> > > recently added should not be global, and should be tied
> > > to the timekeeper's read_base.
> > 
> > But why? its the same hardware clock for both tkr's. Surely if one goes
> > funny the other will too.
> > 
> > It doesn't make sense to duplicate this.
> 
> Well, could it be moved to the timekeeper data structure? What I was 
> opposed to was making it super-global, after all the (nice) effort we 
> made to tidy up global data structures in this area.

Sure, struct timekeeper would work, the debug code already references
the global tk_core to access that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/