linux-kernel - Re: [PATCH 21/21] time: Rework debugging variables so they aren't global

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Apr 2015 10:41:56 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	John Stultz <john.stultz@...aro.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Prarit Bhargava <prarit@...hat.com>,
	Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH 21/21] time: Rework debugging variables so they aren't
 global

On Thu, Apr 02, 2015 at 10:36:47AM +0200, Peter Zijlstra wrote:
> Sure, struct timekeeper would work, the debug code already references
> the global tk_core to access that.

While looking at that, the comment near tk_core says:

/*
 * The most important data for readout fits into a single 64 byte
 * cache line.
 */

I feel that should be qualified somewhat, this is only true for
MONOTONIC (ktime_get()), any other time base ends up on more lines.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/