linux-kernel - Re: [PATCH 7/9] nbd: Remove fixme that was already fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150402090534.GA8341@infradead.org>
Date:	Thu, 2 Apr 2015 02:05:34 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Markus Pargmann <mpa@...gutronix.de>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org,
	nbd-general@...ts.sourceforge.net, kernel@...gutronix.de
Subject: Re: [PATCH 7/9] nbd: Remove fixme that was already fixed

On Thu, Apr 02, 2015 at 10:11:39AM +0200, Markus Pargmann wrote:
> +/*
> + * Forcibly shutdown the socket causing all listeners to error
> + */
>  static void sock_shutdown(struct nbd_device *nbd, int lock)
>  {
> -	/* Forcibly shutdown the socket causing all listeners
> -	 * to error
> -	 *
> -	 * FIXME: This code is duplicated from sys_shutdown, but
> -	 * there should be a more generic interface rather than
> -	 * calling socket ops directly here */
>  	if (lock)
>  		mutex_lock(&nbd->tx_lock);
>  	if (nbd->sock) {

Please also kill the conditional locking here in a future patch by
moving it into the caller.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/