linux-kernel - Re: [PATCH 7/9] nbd: Remove fixme that was already fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150402093620.GN11733@pengutronix.de>
Date:	Thu, 2 Apr 2015 11:36:20 +0200
From:	Markus Pargmann <mpa@...gutronix.de>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org,
	nbd-general@...ts.sourceforge.net, kernel@...gutronix.de
Subject: Re: [PATCH 7/9] nbd: Remove fixme that was already fixed

On Thu, Apr 02, 2015 at 02:05:34AM -0700, Christoph Hellwig wrote:
> On Thu, Apr 02, 2015 at 10:11:39AM +0200, Markus Pargmann wrote:
> > +/*
> > + * Forcibly shutdown the socket causing all listeners to error
> > + */
> >  static void sock_shutdown(struct nbd_device *nbd, int lock)
> >  {
> > -	/* Forcibly shutdown the socket causing all listeners
> > -	 * to error
> > -	 *
> > -	 * FIXME: This code is duplicated from sys_shutdown, but
> > -	 * there should be a more generic interface rather than
> > -	 * calling socket ops directly here */
> >  	if (lock)
> >  		mutex_lock(&nbd->tx_lock);
> >  	if (nbd->sock) {
> 
> Please also kill the conditional locking here in a future patch by
> moving it into the caller.

Yes, thanks. I will make a patch for that.

Best Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)