linux-kernel - Re: [PATCH 00/86] pci: export pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427973330.4063.1410.camel@chaos.site>
Date:	Thu, 02 Apr 2015 13:15:30 +0200
From:	Jean Delvare <jdelvare@...e.de>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Dave Jones <davej@...hat.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups

Le Thursday 02 April 2015 à 12:09 +0200, Michael S. Tsirkin a écrit :
> On Thu, Apr 02, 2015 at 11:04:16AM +0200, Jean Delvare wrote:
> > Le Thursday 02 April 2015 à 01:23 -0700, Christoph Hellwig a écrit :
> > > The class ids are a hardware defintion, not a kernel API.  Just use the
> > > definitions from libpci, or copy over the kernel header if you prefer
> > > it over the libpci definutions.
> > 
> > I agree with Christoph, such defines would better come from
> > pciutils-devel, not the kernel.
> 
> This just leads to code duplication.  Projects that don't link with
> pciutils don't want to depend on it.

Well, they don't have to depend on anything then, they can keep defining
their own named IDs.

Please realize that 1* code duplication is impossible to avoid
completely and 2* this hardly qualifies as code duplication in the first
place (giving symbolic names to constants is not actual programming.)

-- 
Jean Delvare
SUSE L3 Support

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/