linux-kernel - Re: [GIT PULL] qcom SoC changes for v4.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP71WjxbvUZ6p_+=pCNWN5huBcChKy0h8GD+tMM0YeCrZGonMw@mail.gmail.com>
Date:	Thu, 2 Apr 2015 21:47:44 +0200
From:	Nicolas Dechesne <nicolas.dechesne@...aro.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Kumar Gala <galak@...eaurora.org>, arm@...nel.org,
	Olof Johansson <olof@...om.net>, Arnd Bergmann <arnd@...db.de>,
	linux-arm-msm <linux-arm-msm@...r.kernel.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Andy Gross <agross@...eaurora.org>,
	Lina Iyer <lina.iyer@...aro.org>,
	Tyler Baker <tyler.baker@...aro.org>
Subject: Re: [GIT PULL] qcom SoC changes for v4.1

On Thu, Apr 2, 2015 at 9:43 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:
> What about this patch squashed on top? Just guessing but I suspect we
> don't care about cell-index if we're not doing the tcsr stuff. Also, I
> imagine we could get rid of cell-index entirely if we matched against
> the address of the gsbi instead.
>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
>
> ----8<-----
>
> diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
> index 09c669e70d63..ac7d71b6527d 100644
> --- a/drivers/soc/qcom/qcom_gsbi.c
> +++ b/drivers/soc/qcom/qcom_gsbi.c
> @@ -139,7 +139,7 @@ static int gsbi_probe(struct platform_device *pdev)
>         void __iomem *base;
>         struct gsbi_info *gsbi;
>         int i;
> -       u32 mask, gsbi_num;
> +       u32 mask, gsbi_num = 0;
>         const struct crci_config *config = NULL;
>
>         gsbi = devm_kzalloc(&pdev->dev, sizeof(*gsbi), GFP_KERNEL);
> @@ -166,16 +166,19 @@ static int gsbi_probe(struct platform_device *pdev)
>
>                         of_node_put(tcsr_node);
>                 }
> -       }
>
> -       if (of_property_read_u32(node, "cell-index", &gsbi_num)) {
> -               dev_err(&pdev->dev, "missing cell-index\n");
> -               return -EINVAL;
> -       }
> +               if (config) {
> +                       if (of_property_read_u32(node, "cell-index", &gsbi_num)) {
> +                               dev_err(&pdev->dev, "missing cell-index\n");
> +                               return -EINVAL;
> +                       }
> +
> +                       if (gsbi_num < 1 || gsbi_num > MAX_GSBI) {
> +                               dev_err(&pdev->dev, "invalid cell-index\n");
> +                               return -EINVAL;
> +                       }
> +               }
>
> -       if (gsbi_num < 1 || gsbi_num > MAX_GSBI) {
> -               dev_err(&pdev->dev, "invalid cell-index\n");
> -               return -EINVAL;
>         }
>
>         if (of_property_read_u32(node, "qcom,mode", &gsbi->mode)) {


I think it would work, i cannot test right now, i can do it tomorrow
if you need it, but that's pretty much how i tested earlier today (i
had commented out the 2 statements you are putting moving here in the
new if statement.

I did also test with the associated DT patches, and it worked as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/