| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150403100025.GA19317@gondor.apana.org.au> Date: Fri, 3 Apr 2015 18:00:25 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Lokesh Vutla <lokeshvutla@...com> Cc: linux-crypto@...r.kernel.org, linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org, nsekhar@...com, t-kristo@...com Subject: Re: [PATCH v2] crypto: omap-sham: Add the offset of sg page to vaddr On Thu, Apr 02, 2015 at 03:32:45PM +0530, Lokesh Vutla wrote: > kmap_atomic() gives only the page address of the input page. > Driver should take care of adding the offset of the scatterlist > within the page to the returned page address. > omap-sham driver is not adding the offset to page and directly operates > on the return vale of kmap_atomic(), because of which the following > error comes when running crypto tests: > > 00000000: d9 a1 1b 7c aa 90 3b aa 11 ab cb 25 00 b8 ac bf > [ 2.338169] 00000010: c1 39 cd ff 48 d0 a8 e2 2b fa 33 a1 > [ 2.344008] alg: hash: Chunking test 1 failed for omap-sha256 > > So adding the scatterlist offset to vaddr. > > Signed-off-by: Lokesh Vutla <lokeshvutla@...com> Patch applied. Thanks! -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists