linux-kernel - Re: [PATCH] phy: core: Fix error checking in (devm_)phy_optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFRkauA2nrhYO+ts4odH970rNZzG32HQH=gp0WnsQd0NserD_w@mail.gmail.com>
Date:	Wed, 8 Apr 2015 07:32:56 +0800
From:	Axel Lin <axel.lin@...ics.com>
To:	Kishon Vijay Abraham I <kishon@...com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: core: Fix error checking in (devm_)phy_optional_get

2015-04-07 22:21 GMT+08:00 Kishon Vijay Abraham I <kishon@...com>:
> Hi,
>
> On Tuesday 07 April 2015 05:13 PM, Axel Lin wrote:
>>
>> Don't pass valid pointer to PTR_ERR, use PTR_ERR(phy) only when
>> IS_ERR(phy) is true.
>>
>> Signed-off-by: Axel Lin <axel.lin@...ics.com>
>> ---
>>   drivers/phy/phy-core.c | 12 ++++++++----
>>   1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
>> index 3791838f..f112fff 100644
>> --- a/drivers/phy/phy-core.c
>> +++ b/drivers/phy/phy-core.c
>> @@ -530,8 +530,10 @@ struct phy *phy_optional_get(struct device *dev,
>> const char *string)
>>   {
>>         struct phy *phy = phy_get(dev, string);
>>
>> -       if (PTR_ERR(phy) == -ENODEV)
>> -               phy = NULL;
>> +       if (IS_ERR(phy)) {
>> +               if (PTR_ERR(phy) == -ENODEV)
>
>
> This can simply be (IS_ERR(phy) && (PTR_ERR(phy) == -ENODEV)).
ok, I just sent v2.

> But I don't see a problem passing a valid pointer to PTR_ERR here.
I'm not very sure if it's correct to do so.
My understanding is the PTR_ERR is supposed to be used for invalid pointer.

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/