linux-kernel - Re: [PATCH] KVM: vmx: pass error code with internal error #2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5523BCA4.4070601@redhat.com>
Date:	Tue, 07 Apr 2015 13:16:52 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Radim Krčmář <rkrcmar@...hat.com>,
	linux-kernel@...r.kernel.org
CC:	kvm@...r.kernel.org
Subject: Re: [PATCH] KVM: vmx: pass error code with internal error #2



On 02/04/2015 21:11, Radim Krčmář wrote:
> Exposing the on-stack error code with internal error is cheap and
> potentially useful.
> 
> Signed-off-by: Radim Krčmář <rkrcmar@...hat.com>
> ---
>  arch/x86/kvm/vmx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 0caaf56eb459..cfbd737afcd1 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -5089,9 +5089,10 @@ static int handle_exception(struct kvm_vcpu *vcpu)
>  	    !(is_page_fault(intr_info) && !(error_code & PFERR_RSVD_MASK))) {
>  		vcpu->run->exit_reason = KVM_EXIT_INTERNAL_ERROR;
>  		vcpu->run->internal.suberror = KVM_INTERNAL_ERROR_SIMUL_EX;
> -		vcpu->run->internal.ndata = 2;
> +		vcpu->run->internal.ndata = 3;
>  		vcpu->run->internal.data[0] = vect_info;
>  		vcpu->run->internal.data[1] = intr_info;
> +		vcpu->run->internal.data[2] = error_code;
>  		return 0;
>  	}
>  
> 

Applied, thanks.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/