linux-kernel - Re: [PATCH 3/5] spi: img-spfi: Implement an unprepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150407111738.GI6023@sirena.org.uk>
Date:	Tue, 7 Apr 2015 12:17:38 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Andrew Bresticker <abrestic@...omium.org>
Cc:	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ezequiel Garcia <ezequiel.garcia@...tec.com>
Subject: Re: [PATCH 3/5] spi: img-spfi: Implement an unprepare_message()
 callback

On Mon, Apr 06, 2015 at 02:29:05PM -0700, Andrew Bresticker wrote:

> The driver can be greatly simplified by moving the transfer
> finishing and timeout handling to an unprepare_message() callback.

The timeout handling would actually be better moved to the handle_err()
callback which is provided for that purpose.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)