linux-kernel - Re: [PATCH 4/5] spi: img-spfi: Setup TRANSACTION register before CONTROL register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150407112306.GL6023@sirena.org.uk>
Date:	Tue, 7 Apr 2015 12:23:06 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Andrew Bresticker <abrestic@...omium.org>
Cc:	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sifan Naeem <sifan.naeem@...tec.com>
Subject: Re: [PATCH 4/5] spi: img-spfi: Setup TRANSACTION register before
 CONTROL register

On Mon, Apr 06, 2015 at 02:29:06PM -0700, Andrew Bresticker wrote:
> From: Sifan Naeem <sifan.naeem@...tec.com>
> 
> Setting the transfer length in the TRANSACTION register after the
> CONTROL register is programmed causes intermittent timeout issues in
> SPFI transfers when using the SPI framework to control the CS GPIO
> lines.  To avoid this issue, set transfer length before programming
> the CONTROL register.

This is fine but it appears to be a bug fix and therefore should have
been at the start of the series so it could be applied as such and sent
to Linus.  As it is it depends on the refactoring for prepare() which
prevents that, please regenerate against Linus' tree so it can be sent
as a fix.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)