linux-kernel - Re: [PATCH V2 2/6] i2c: qup: Add V2 tags support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150407050640.GB9225@qualcomm.com>
Date:	Tue, 7 Apr 2015 00:06:40 -0500
From:	Andy Gross <agross@...eaurora.org>
To:	Sricharan R <sricharan@...eaurora.org>
Cc:	devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org,
	galak@...eaurora.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, iivanov@...sol.com,
	srichara@....qualcomm.com
Subject: Re: [PATCH V2 2/6] i2c: qup: Add V2 tags support

On Tue, Apr 07, 2015 at 12:01:03AM +0530, Sricharan R wrote:

<snip>

> +static u32 qup_i2c_send_data(struct qup_i2c_dev *qup, int tlen, u8 *tbuf,
> +			     int dlen, u8 *dbuf)
> +{
> +	u32 val = 0, idx = 0, pos = 0, i = 0, t;
> +	int  len = tlen + dlen;
> +	u8 *buf = tbuf;
> +
> +	while (len > 0) {
> +		if (qup_i2c_wait_ready(qup, QUP_OUT_FULL, 0, 4)) {

Instead of 0 and 4 can we use some #defines?  This applies for all of the
i2c_wait_ready calls

<snip>


-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/