linux-kernel - RE: [PATCH V2 2/6] i2c: qup: Add V2 tags support

Open Source and information security mailing list archives

Date:	Wed, 8 Apr 2015 11:00:49 +0530
From:	"Sricharan" <sricharan@...eaurora.org>
To:	"'Andy Gross'" <agross@...eaurora.org>
Cc:	<devicetree@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
	<iivanov@...sol.com>, <galak@...eaurora.org>,
	<dmaengine@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH V2 2/6] i2c: qup: Add V2 tags support

Hi Andy,

> -----Original Message-----
> From: linux-arm-kernel [mailto:linux-arm-kernel-
> bounces@...ts.infradead.org] On Behalf Of Andy Gross
> Sent: Tuesday, April 07, 2015 10:37 AM
> To: Sricharan R
> Cc: srichara@....qualcomm.com; devicetree@...r.kernel.org; linux-arm-
> msm@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> i2c@...r.kernel.org; iivanov@...sol.com; galak@...eaurora.org;
> dmaengine@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH V2 2/6] i2c: qup: Add V2 tags support
> 
> On Tue, Apr 07, 2015 at 12:01:03AM +0530, Sricharan R wrote:
> 
> <snip>
> 
> > +static u32 qup_i2c_send_data(struct qup_i2c_dev *qup, int tlen, u8
*tbuf,
> > +			     int dlen, u8 *dbuf)
> > +{
> > +	u32 val = 0, idx = 0, pos = 0, i = 0, t;
> > +	int  len = tlen + dlen;
> > +	u8 *buf = tbuf;
> > +
> > +	while (len > 0) {
> > +		if (qup_i2c_wait_ready(qup, QUP_OUT_FULL, 0, 4)) {
> 
> Instead of 0 and 4 can we use some #defines?  This applies for all of the
> i2c_wait_ready calls
> 
> <snip>
> 
 Ok, will change this with some macro.

Regards,
 Sricharan

> 
> --
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum, a Linux Foundation Collaborative Project
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives