linux-kernel - Re: [PATCH V2] x86/numa: kernel stack corruption fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150408021836.GA2464@dhcp-16-105.nay.redhat.com>
Date:	Wed, 8 Apr 2015 10:18:36 +0800
From:	Baoquan He <bhe@...hat.com>
To:	Xishi Qiu <qiuxishi@...wei.com>
Cc:	Dave Young <dyoung@...hat.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, tglx@...utronix.de,
	akpm@...ux-foundation.org, isimatu.yasuaki@...fujitsu.com,
	mingo@...hat.com, hpa@...or.com
Subject: Re: [PATCH V2] x86/numa: kernel stack corruption fix

On 04/08/15 at 09:59am, Xishi Qiu wrote:
> On 2015/4/8 9:46, Dave Young wrote:
> 
> >>>  
> >>> -	/* Mark all kernel nodes. */
> >>> +	/*
> >>> +	 * Mark all kernel nodes.
> >>> +	 *
> >>> +	 * In case booting with mem=nn[kMG] or in kdump kernel, numa_meminfo
> >>
> >> Hi Dave,
> >>
> >> It should both set mem=xx and numa=off, then numa_meminfo may not include all
> >> the memblock.reserved memory, right?
> > 
> > Yasuaki Ishimatsu suggests to remove numa=off in comment because in theory there's such
> > possiblity that it may happen even without numa=off. Just consider the non-snb board..
> > 
> > Thanks
> > Dave
> > 
> 
> Hi Dave,
> 
> I made a mistake, when numa is on, numa_meminfo is from SRAT, but it will be cut
> in numa_cleanup_meminfo(), so the bug is not related to numa on/off. Your comment
> is right.

Hi Xishi,

>From code flow it's exact as you said. And if remove numa=off bug should
be reproduced alwasy. I talked to Dave, he said error didn't occur when
he remove numa=off. That is too weird.

Thanks
Baoquan > 
> 
> > .
> > 
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/