linux-kernel - Re: [PATCH V2] x86/numa: kernel stack corruption fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55248B68.7000308@huawei.com>
Date:	Wed, 8 Apr 2015 09:59:04 +0800
From:	Xishi Qiu <qiuxishi@...wei.com>
To:	Dave Young <dyoung@...hat.com>
CC:	<x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<tglx@...utronix.de>, <bhe@...hat.com>,
	<akpm@...ux-foundation.org>, <isimatu.yasuaki@...fujitsu.com>,
	<mingo@...hat.com>, <hpa@...or.com>
Subject: Re: [PATCH V2] x86/numa: kernel stack corruption fix

On 2015/4/8 9:46, Dave Young wrote:

>>>  
>>> -	/* Mark all kernel nodes. */
>>> +	/*
>>> +	 * Mark all kernel nodes.
>>> +	 *
>>> +	 * In case booting with mem=nn[kMG] or in kdump kernel, numa_meminfo
>>
>> Hi Dave,
>>
>> It should both set mem=xx and numa=off, then numa_meminfo may not include all
>> the memblock.reserved memory, right?
> 
> Yasuaki Ishimatsu suggests to remove numa=off in comment because in theory there's such
> possiblity that it may happen even without numa=off. Just consider the non-snb board..
> 
> Thanks
> Dave
> 

Hi Dave,

I made a mistake, when numa is on, numa_meminfo is from SRAT, but it will be cut
in numa_cleanup_meminfo(), so the bug is not related to numa on/off. Your comment
is right.

Reviewed-by: Xishi Qiu <qiuxishi@...wei.com>

> .
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/